Re: Cleaning up threading code
Thomas Munro <thomas.munro@gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Peter Eisentraut <peter@eisentraut.org>,
Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-07-11T20:58:29Z
Lists: pgsql-hackers
On Mon, Jul 10, 2023 at 10:45 AM Thomas Munro <thomas.munro@gmail.com> wrote: > * defined ENABLE_THREAD_SAFETY 1 in c.h, for the benefit of extensions I may lack imagination but I couldn't think of any use for that vestigial macro in backend/extension code, and client code doesn't see c.h and might not get the right answer anyway if it's dynamically linked which is the usual case. I took it out for now. Open to discussing further if someone can show what kinds of realistic external code would be affected. > * defined ENABLE_THREAD_SAFETY 1 ecpg_config.h, for the benefit of ECPG clients I left this one in. I'm not sure if it could really be needed. Perhaps at a stretch, perhaps ECPG code that is statically linked might test that instead of calling PQisthreadsafe(). Pushed.
Commits
-
Doc: Adjust libpq docs about thread safety.
- ce0b0fa3e792 17.0 landed
-
Remove --disable-thread-safety and related code.
- 68a4b58eca03 17.0 landed
-
Rename port/thread.c to port/user.c.
- 89333db963af 17.0 landed
-
Remove obsolete comment and code from fe-auth.c.
- 1aadc504bf47 17.0 landed