Horton

Re: BUG #17928: Standby fails to decode WAL on termination of primary

Thomas Munro <thomas.munro@gmail.com>

View thread
From: Thomas Munro <thomas.munro@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alexander Lakhin <exclusion@gmail.com>, Sergei Kornilov <sk@zsrv.org>, Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-bugs@lists.postgresql.org, Fujii Masao <masao.fujii@oss.nttdata.com>
Date: 2023-09-19T10:09:10Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Correct assertion and comments about XLogRecordMaxSize.

  2. Fix edge-case for xl_tot_len broken by bae868ca.

  3. Don't use Perl pack('Q') in 039_end_of_wal.pl.

  4. Don't trust unvalidated xl_tot_len.

  5. Make recovery report error message when invalid page header is found.

  6. Add more protections in WAL record APIs against overflows

On Tue, Sep 19, 2023 at 9:53 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Tue, Sep 19, 2023 at 09:25:34PM +1200, Thomas Munro wrote:
> > The problem was that the Perl functions advance_XXX() would sometimes
> > see an "unflushed" insert position caused by hint records and other
> > incidental stuff, and then we'd write our contrived header at a
> > disconnected location after a bunch of (unwritten) zeroes.  The
> > solution in this version is to start each test with
> > emit_message($node, 0), which flushes a small record.
>
> Makes sense.  Does this also address the other issue you've noticed on
> v12 when ICU is enabled (the one with the initial LSN changed after
> initdb)?

Yep.