Re: psql tab-complete

Thomas Munro <thomas.munro@gmail.com>

From: Thomas Munro <thomas.munro@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Victor Spirin <v.spirin@postgrespro.ru>, pgsql-hackers@lists.postgresql.org
Date: 2022-12-22T05:36:58Z
Lists: pgsql-hackers
On Thu, Dec 22, 2022 at 3:25 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Wed, Dec 21, 2022 at 05:56:05PM -0500, Tom Lane wrote:
> > Thomas Munro <thomas.munro@gmail.com> writes:
> >> Since I really want to be able to use VA_ARGS_NARGS() elsewhere,
> >
> > +1, that'd be handy.
> >
> >> ... Assuming those switches actually work as claimed, I see
> >> two choices: commit this hack with a comment reminding us to clean it
> >> up later, or drop 2015.
> >
> > As long as we can hide the messiness inside a macro definition,
> > I'd vote for the former.
>
> Agreed, even if it is worth noting that all the buildfarm members
> with MSVC use 2017 or newer.

Thanks.  Pushed.

PS is it a mistake that we still mention SDK 8.1 in the docs?



Commits

  1. Add work-around for VA_ARGS_NARGS() on MSVC.