GCC warning in back branches

Thomas Munro <thomas.munro@gmail.com>

From: Thomas Munro <thomas.munro@gmail.com>

To: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2021-02-15T01:15:51Z

Lists: pgsql-hackers

Attachments

0001-Fix-compiler-warning-in-back-branches.patch (text/x-patch) patch 0001

Hi,

guc.c: In function ‘RestoreGUCState’:
guc.c:9455:4: error: ‘varsourceline’ may be used uninitialized in this
function [-Werror=maybe-uninitialized]
 9455 |    set_config_sourcefile(varname, varsourcefile, varsourceline);
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I propose the attached.

Commits

Fix compiler warning in back branches (9.6, 10).
- 618d139f82d4 9.6.22 landed
- 26812bcaa664 10.17 landed
Fix assorted compiler warnings seen in the buildfarm.
- fbb2e9a030ee 11.0 cited