Horton

Re: cpluspluscheck vs ICU

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter@eisentraut.org>
Date: 2022-03-23T02:52:34Z
Lists: pgsql-hackers 
On Wed, Mar 23, 2022 at 3:23 PM Andres Freund <andres@anarazel.de> wrote:
> On 2022-03-22 17:20:24 -0700, Andres Freund wrote:
> > I was about to propose adding headerscheck / cpluspluscheck to the CI file so
> > that cfbot can catch future issues.
>
> The attached patch does so, with ICU disabled to avoid the problems discussed
> in the thread. Example run:
> https://cirrus-ci.com/task/6326161696358400?logs=headers_headerscheck#L0
>
> Unless somebody sees a reason not to, I'm planning to commit this soon.

LGTM.

Commits

  1. Hide ICU C++ APIs from pg_locale.h

  2. ci: test headerscheck, cpluspluscheck as part of CompilerWarnings task.