Re: race condition when writing pg_control

Thomas Munro <thomas.munro@gmail.com>

From: Thomas Munro <thomas.munro@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: "Bossart, Nathan" <bossartn@amazon.com>, Fujii Masao <masao.fujii@oss.nttdata.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2020-06-02T22:56:13Z
Lists: pgsql-hackers
On Tue, Jun 2, 2020 at 5:24 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Sun, May 31, 2020 at 09:11:35PM +0000, Bossart, Nathan wrote:
> > Thanks for the feedback.  I've attached a new set of patches.
>
> Thanks for splitting the set.  0001 and 0002 are the minimum set for
> back-patching, and it would be better to merge them together.  0003 is
> debatable and not an actual bug fix, so I would refrain from doing a
> backpatch.  It does not seem that there is a strong consensus in favor
> of 0003 either.
>
> Thomas, are you planning to look at this patch set?

Sorry for my radio silence, I got tangled up with a couple of
conferences.  I'm planning to look at 0001 and 0002 shortly.



Commits

  1. Fix locking bugs that could corrupt pg_control.