Horton

Thread

Commits

  1. Fix cpluspluscheck for pg_verifybackup.h.

  1. CI cpluspluscheck failures

    Thomas Munro <thomas.munro@gmail.com> — 2024-08-18T12:10:40Z

    Hi,

The CompilerWarnings cspluspluscheck started failing recently.

1.  LLVM library version issue.  See commit message for details.
2.  pg_verify_backup.h now uses simplehash.h, which references
pg_fatal(), which nobody declared.

I'm not sure why the first one started happening at the commit
(aa2d6b15) that caused the second one, I feel like I'm missing
something...

https://github.com/postgres/postgres/commits/master/

Anyway, these patches turn it green for me.  Please see attached.

https://cirrus-ci.com/task/5014011601747968

  2. Re: CI cpluspluscheck failures

    Thomas Munro <thomas.munro@gmail.com> — 2024-08-18T20:02:00Z

    On Mon, Aug 19, 2024 at 12:10 AM Thomas Munro <thomas.munro@gmail.com> wrote:
> I'm not sure why the first one started happening at the commit
> (aa2d6b15) that caused the second one, I feel like I'm missing
> something...

What I was missing is that the LLVM warnings were already present, but
not causing failures because they are "system" headers.  So I'll go
and push the fix for aa2d6b15, and wait longer for comment on the LLVM
one which has been wrong, but green, for a while.

  3. Re: CI cpluspluscheck failures

    Amul Sul <sulamul@gmail.com> — 2024-08-20T04:53:58Z

    On Mon, Aug 19, 2024 at 1:30 AM Thomas Munro <thomas.munro@gmail.com> wrote:
>
> On Mon, Aug 19, 2024 at 12:10 AM Thomas Munro <thomas.munro@gmail.com> wrote:
> > I'm not sure why the first one started happening at the commit
> > (aa2d6b15) that caused the second one, I feel like I'm missing
> > something...

Thanks, Thomas, for addressing the missing include.

Adding logging.h to the pg_verifybackup.h file makes it redundant in
pg_verifybackup.c. The attached patch proposes removing this redundant
include from pg_verifybackup.c, along with a few other unnecessary
includes.

Regards,
Amul