Horton

Re: Adding SMGR discriminator to buffer tags

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Shawn Debnath <sdn@amazon.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-07-11T22:16:21Z
Lists: pgsql-hackers

Attachments

On Fri, May 10, 2019 at 8:54 AM Shawn Debnath <sdn@amazon.com> wrote:
> On Wed, May 08, 2019 at 06:31:04PM +1200, Thomas Munro wrote:
> Looks good to me. Minor nit: update the comment for XLogRecGetBlockTag:

Fixed.  Also fixed broken upgrade scripts for pg_buffercache
extension, as pointed out by Robert[1] on the main thread where undo
stuff is being discussed. Attempts to keep subtopics separated have so
far failed, so the thread ostensibly about orphaned file cleanup is
now about undo work allocation, but I figured it'd be useful to
highlight this patch separately as it'll be the first to go in, and
it's needed by your work Shawn.  So I hope we're still on the same
page with this refactoring patch.

One thing I'm not sure about is the TODO message in parsexlog.c's
extractPageInfo() function.

[1] https://www.postgresql.org/message-id/CA%2BTgmob4htT-9Tq7eHG3wS%3DdpKFbQZOyqgSr1iWmV_65Duz6Pw%40mail.gmail.com

-- 
Thomas Munro
https://enterprisedb.com

Commits

  1. Move some md.c-specific logic from smgr.c to md.c.

  2. Refactor the fsync queue for wider use.