Re: small improvement of the elapsed time for truncating heap in vacuum
Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
From: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
To: Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-02-17T04:07:00Z
Lists: pgsql-hackers
On Mon, 17 Feb 2020 at 12:44, Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com> wrote: > > Hi, > > On Fri, Feb 14, 2020 at 4:50 PM Fujii Masao <masao.fujii@gmail.com> wrote: > > Regarding the patch, isn't it better to put pg_rusage_init() at the > > top of do loop block? If we do this, as a side-effect, we can get > > rid of pg_rusage_init() at the top of lazy_truncate_heap(). > Thanks for your reply. > Yeah, it makes sense. > > Attached patch moves pg_rusage_init() to the top of do-loop-block. +1 to reset for each truncation loops. For the patch, we can put also the declaration of ru0 into the loop. Regards, -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Fix mesurement of elapsed time during truncating heap in VACUUM.
- 4a3f164b74f5 9.5.22 landed
- 307c27037444 9.6.18 landed
- 79f344d52bd5 10.13 landed
- 414ed1ca2321 11.8 landed
- 16e6c968be64 12.3 landed
- 007491979461 13.0 landed