Horton

Re: base backup client as auxiliary backend process

Masahiko Sawada <masahiko.sawada@2ndquadrant.com>

View thread View on postgr.es
From: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>, Michael Paquier <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-01-15T00:40:38Z
Lists: pgsql-hackers 
On Tue, 14 Jan 2020 at 22:58, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
>
> On 2020-01-14 07:32, Masahiko Sawada wrote:
> > -     <entry>Replication slot name used by this WAL receiver</entry>
> > +     <entry>
> > +      Replication slot name used by this WAL receiver.  This is only set if a
> > +      permanent replication slot is set using <xref
> > +      linkend="guc-primary-slot-name"/>.  Otherwise, the WAL receiver may use
> > +      a temporary replication slot (determined by <xref
> > +      linkend="guc-wal-receiver-create-temp-slot"/>), but these are not shown
> > +      here.
> > +     </entry>
> >
> > Now that the slot name is shown even if it's a temp slot the above
> > documentation changes needs to be changed. Other changes look good to
> > me.
>
> committed, thanks

Thank you for committing these patches.

Could you rebase the main patch that adds base backup client as
auxiliary backend process since the previous version patch (v3)
conflicts with the current HEAD?

Regards,

-- 
Masahiko Sawada            http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Factor out InitControlFile() from BootStrapXLOG()

  2. Reformat code comment

  3. pg_resetwal: Rename function to avoid potential conflict

  4. Expose PQbackendPID() through walreceiver API

  5. walreceiver uses a temporary replication slot by default

  6. Make lsn argument of walrcv_create_slot() optional

  7. More precise errors from initial pg_control check