Re: [patch] some PQExpBuffer are not destroyed in pg_dump

Masahiko Sawada <masahiko.sawada@2ndquadrant.com>

From: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>

To: "Zhang, Jie" <zhangjie2@cn.fujitsu.com>

Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2020-04-13T07:51:06Z

Lists: pgsql-hackers

On Tue, 7 Apr 2020 at 11:42, Zhang, Jie <zhangjie2@cn.fujitsu.com> wrote:
>
> Hi al
>
> In getDefaultACLs function, some PQExpBuffer are not destroy
>

Yes, it looks like an oversight. It's related to the commit
e2090d9d20d809 which is back-patched to 9.6.

The patch looks good to me.

Regards,

-- 
Masahiko Sawada            http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

Fix minor memory leak in pg_dump
- 45d328bde659 9.6.18 landed
- e7887fe00db2 10.13 landed
- 7347855c4652 11.8 landed
- d70c014624dd 12.3 landed
- 8f4ee44bcdbc 13.0 landed
pg_dump: Fix handling of ALTER DEFAULT PRIVILEGES
- e2090d9d20d8 10.0 cited