Re: [PATCH] Warn when io_min_workers exceeds io_max_workers

Baji Shaik <baji.pgdev@gmail.com>

From: Baji Shaik <baji.pgdev@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tristan Partin <tristan@partin.io>, PostgreSQL-development <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-23T02:47:06Z
Lists: pgsql-hackers

Attachments

On Mon, Jun 22, 2026 at 8:29 PM Michael Paquier <michael@paquier.xyz> wrote:

> Let's adjust the messages so as the GUC parameters are included as %s
> in the error strings, and apply the same thing for the autovacuum
> path.  A benefit is that we are then able to reduce the translation
> work churn with only one message to translate for both.  Hence, I'd
> suggest to reword the error messages of both as of:
> "\"%s\" (%d) should be less than or equal to \"%s\" (%d)",
> "guc_max_min", min_val, "guc_min_name", max_val
>

Thanks for the suggestion, Michael.

Attached v2 with two patches:

0001 - Adds check_io_worker_gucs() with parameterized GUC names (%s)
0002 - Adjusts check_av_worker_gucs() to use the same format

Both now produce the same translatable errmsg pattern:
 "\"%s\" (%d) should be less than or equal to \"%s\" (%d)"

Thanks,
Baji Shaik.

Commits

  1. Use placeholders and not GUC names in error message (autovacuum)