Horton

Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

Stéphane Tachoires <stephane.tachoires@gmail.com>

View thread
From: Stéphane Tachoires <stephane.tachoires@gmail.com>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Dmitry Koval <d.koval@postgrespro.ru>, pgsql-hackers@lists.postgresql.org
Date: 2025-12-10T20:04:11Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Adjust errcode in checkPartition()

  2. Fix usage of palloc() in MERGE/SPLIT PARTITION(s) code

  3. Implement ALTER TABLE ... SPLIT PARTITION ... command

  4. Implement ALTER TABLE ... MERGE PARTITIONS ... command

  5. Calculate agglevelsup correctly when Aggref contains a CTE.

  6. Use PqMsg_* macros in applyparallelworker.c.

  7. Restrict psql meta-commands in plain-text dumps.

  8. Ensure we have a snapshot when updating various system catalogs.

  9. Use specific collation where needed in new test

  10. Expand virtual generated columns in the planner

  11. Virtual generated columns

  12. Define PG_LOGICAL_DIR for path pg_logical/ in data folder

  13. Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) commands

  14. Avoid repeated table name lookups in createPartitionTable()

  15. Provide deterministic order for catalog queries in partition_split.sql

  16. Don't copy extended statistics during MERGE/SPLIT partition operations

  17. Fix the name collision detection in MERGE/SPLIT partition operations

  18. Fix regression tests conflict in 3ca43dbbb6

  19. Add permission check for MERGE/SPLIT partition operations

  20. Fix one more portability shortcoming in new test_pg_dump test.

  21. Inherit parent's AM for partition MERGE/SPLIT operations

  22. Add tab completion for partition MERGE/SPLIT operations

  23. Rename tables in tests of partition MERGE/SPLIT operations

  24. Make new partitions with parent's persistence during MERGE/SPLIT

  25. Document the way partition MERGE/SPLIT operations create new partitions

  26. Change the way ATExecMergePartitions() handles the name collision

  27. Grammar fixes for split/merge partitions code

  28. Checks for ALTER TABLE ... SPLIT/MERGE PARTITIONS ... commands

  29. Fix some grammer errors from error messages and codes comments

  30. Support TZ and OF format codes in to_timestamp().

  31. Support identity columns in partitioned tables

  32. Fix indentation in twophase.c

  33. Fix corner-case planner failure for MERGE.

  34. Doc: fix documentation example for bytea hex output format.

  35. Avoid repeated name lookups during table and index DDL.

Hi,

Patches don't apply anymore.
Could you rebase it please ?

Thank you so much to all of you for your persistence.
Stéphane.
Back.

Le mer. 10 déc. 2025 à 00:54, Alexander Korotkov
<aekorotkov@gmail.com> a écrit :
>
> On Wed, Dec 10, 2025 at 1:22 AM Dmitry Koval <d.koval@postgrespro.ru> wrote:
> > Thank you for your corrections!
> > Two questions:
> > ----
> >
> > 1) "v65-0001-Implement-ALTER-TABLE-.-MERGE-PARTITIONS-.-comma.patch"
> >   patch, "src/backend/partitioning/partbounds.c" file,
> > "check_two_partitions_bounds_range" function.
> >
> > Old comment (v64)
> >
> > +       /*
> > +        * lower1=false (the second to last argument) for correct comparison of
> > +        * lower and upper bounds.
> > +        */
> >
> > was changed to (v65)
> >
> > +       /*
> > +        * cmpval == false for the correct comparison result of the lower and
> > +        * upper bounds.
> > +        */
> >
> > Maybe it's better to keep the old comment (or keep its meaning)?
> > ----
> >
> > 2) "v65-0002-Implement-ALTER-TABLE-.-SPLIT-PARTITION-.-comman.patch"
> > patch, "src/backend/parser/parse_utilcmd.c" file, "checkPartition" function.
> >
> > The third argument of function was changed from "is_merge" (v64) to
> > "isMerge" (v65). Maybe the function description should be changed in
> > the same way?
> >
> > + * is_merge: true indicates the operation is "ALTER TABLE ... MERGE
> > PARTITIONS";
>
> Thank you for catching this.  Both accepted.
>
> ------
> Regards,
> Alexander Korotkov
> Supabase