Horton

Re: [PATCH] Porting small OpenBSD changes.

David CARLIER <devnexen@gmail.com>

View thread View on postgr.es
From: David CARLIER <devnexen@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Date: 2017-11-20T18:57:47Z
Lists: pgsql-hackers

Attachments

On 20 November 2017 at 18:49, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> David CARLIER <devnexen@gmail.com> writes:
> > - Reducing OpenBSD postfgresql maintainer internal changes bookeeping if
> > those small changes make sense for the PostgreSQL developers.
>
> Hm.  The s_lock.c change is surely fine if OpenBSD maintainers say it is.
>
> Not sure about adding Motorola 88K support to s_lock.h ... is anybody
> really still interested in that platform?


Yes there is :-)


> OTOH, we still have M68K
> and VAX stanzas in that file, so I suppose it's silly to complain
> about 88K.  A bigger issue is that I wonder whether that code has
> ever been tested: it does not look to me like the __asm__ call is
> even syntactically correct.  There should be colons in it.
>
>
True :-) corrected. Thanks.


>                         regards, tom lane
>

Commits

  1. Add support for Motorola 88K to s_lock.h.

  2. Use out-of-line M68K spinlock code for OpenBSD as well as NetBSD.