Horton

Re: clog double-dip in heap_hot_search_buffer

Simon Riggs <simon@2ndquadrant.com>

View thread
From: Simon Riggs <simon@2ndQuadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Date: 2012-05-02T16:16:45Z
Lists: pgsql-hackers 
On Wed, May 2, 2012 at 5:07 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Wed, May 2, 2012 at 12:06 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> +     /* Deleter committed, so tuple is alive if the XID is old enough. */
>>> +     return TransactionIdPrecedes(HeapTupleHeaderGetXmax(tuple), OldestXmin);
>>
>> s/alive/dead/ in that comment?
>
> Yep, good catch, thanks.
>
>> Otherwise this seems like a good idea.
>
> Do you think I should apply this to 9.2, or wait until 9.3?

Now please. Well done.

-- 
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services