Re: Should I implement DROP INDEX CONCURRENTLY?
Simon Riggs <simon@2ndquadrant.com>
From: Simon Riggs <simon@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter_e@gmx.net>, Daniel Farina <daniel@heroku.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2012-01-19T15:02:31Z
Lists: pgsql-hackers
Attachments
- drop_index_concurrently.v2.patch (text/x-patch) patch v2
On Wed, Jan 18, 2012 at 11:12 PM, Robert Haas <robertmhaas@gmail.com> wrote: > On Wed, Jan 18, 2012 at 5:49 PM, Simon Riggs <simon@2ndquadrant.com> wrote: >> Can I just check with you that the only review comment is a one line >> change? Seems better to make any additional review comments in one go. > > No, I haven't done a full review yet - I just noticed that right at > the outset and wanted to be sure that got addressed. I can look it > over more carefully, and test it. Corrected your point, and another found during retest. Works as advertised, docs corrected. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services