Horton

Re: allowing multiple PQclear() calls

Simon Riggs <simon@2ndquadrant.com>

View thread View on postgr.es
From: Simon Riggs <simon@2ndQuadrant.com>
To: Boszormenyi Zoltan <zb@cybertec.at>
Cc: Marko Kreen <markokr@gmail.com>, Josh Kupershmidt <schmiddy@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2012-12-11T15:09:05Z
Lists: pgsql-hackers 
On 11 December 2012 12:18, Boszormenyi Zoltan <zb@cybertec.at> wrote:

>>> Such mechanism already exist - you just need to set
>>> your PGresult pointer to NULL after each PQclear().
>>
>> So why doesn't PQclear() do that?
>
>
> Because then PQclear() would need a ** not a *. Do you want its
> interface changed for 9.3 and break compatibility with previous versions?

No, but we should introduce a new public API call that is safer,
otherwise we get people continually re-inventing new private APIs that
Do the Right Thing, as the two other respondents have shown.

-- 
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services