Re: 16-bit page checksums for 9.2
Simon Riggs <simon@2ndquadrant.com>
From: Simon Riggs <simon@2ndQuadrant.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Jim Nasby <jim@nasby.net>, Kevin Grittner <Kevin.Grittner@wicourts.gov>, Andres Freund <andres@anarazel.de>, aidan@highrise.ca, stark@mit.edu, pgsql-hackers@postgresql.org
Date: 2012-01-06T10:30:53Z
Lists: pgsql-hackers
On Fri, Jan 6, 2012 at 1:10 AM, Stephen Frost <sfrost@snowman.net> wrote: > * Simon Riggs (simon@2ndQuadrant.com) wrote: >> I discover that non-all-zeroes holes are fairly common, just not very frequent. > > Curious, might be interesting to find out why. > >> That may or may not be a problem, but not something to be dealt with >> here and now. > > But I agree that it's not the job of this patch/effort. It sounds like > we have clear indication, however, that those areas, as they are not > necessairly all zeros, should be included in the checksum. Disagree. Full page writes ignore the hole, so its appropriate to do so here also. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services