Horton

Re: Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]

Simon Riggs <simon@2ndquadrant.com>

View thread View on postgr.es
From: Simon Riggs <simon@2ndQuadrant.com>
To: Amit Kapila <amit.kapila@huawei.com>
Cc: Kevin Grittner <kgrittn@mail.com>, robertmhaas@gmail.com, josh@agliodbs.com, pgsql-hackers@postgresql.org
Date: 2013-01-09T11:22:06Z
Lists: pgsql-hackers 
On 24 December 2012 16:57, Amit Kapila <amit.kapila@huawei.com> wrote:

> Performance: Average of 3 runs of pgbench in tps
> 9.3devel  |  with trailing null patch
> ----------+--------------------------
> 578.9872  |   573.4980

On balance, it would seem optimizing for this special case would
affect everybody negatively; not much, but enough. Which means we
should rekect this patch.

Do you have a reason why a different view might be taken?

-- 
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Commits

  1. Don't assume that a tuple's header size is unchanged during toasting.