Re: Separating bgwriter and checkpointer
Simon Riggs <simon@2ndquadrant.com>
From: Simon Riggs <simon@2ndQuadrant.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-10-02T12:10:27Z
Lists: pgsql-hackers
Attachments
- bgwriter_split.v1a.patch (application/octet-stream) patch
On Fri, Sep 16, 2011 at 2:38 AM, Fujii Masao <masao.fujii@gmail.com> wrote: > On Fri, Sep 16, 2011 at 7:53 AM, Simon Riggs <simon@2ndquadrant.com> wrote: >> This patch splits bgwriter into 2 processes: checkpointer and >> bgwriter, seeking to avoid contentious changes. Additional changes are >> expected in this release to build upon these changes for both new >> processes, though this patch stands on its own as both a performance >> vehicle and in some ways a refcatoring to simplify the code. > > I like this idea to simplify the code. How much performance gain can we > expect by this patch? > >> Current patch has a bug at shutdown I've not located yet, but seems >> likely is a simple error. That is mainly because for personal reasons >> I've not been able to work on the patch recently. I expect to be able >> to fix that later in the CF. > > You seem to have forgotten to include checkpointor.c and .h in the patch. Original patch included here. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services