Horton
Menu

Re: Patch for option in pg_resetxlog for restore from WAL files

Simon Riggs <simon@2ndquadrant.com>

View thread
From: Simon Riggs <simon@2ndQuadrant.com>
To: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: Amit kapila <amit.kapila@huawei.com>, "robertmhaas@gmail.com" <robertmhaas@gmail.com>, "tgl@sss.pgh.pa.us" <tgl@sss.pgh.pa.us>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Andres Freund <andres@2ndquadrant.com>
Date: 2012-09-25T12:56:36Z
Lists: pgsql-hackers 
On 24 September 2012 04:00, Heikki Linnakangas <hlinnakangas@vmware.com> wrote:
> On 18.07.2012 16:47, Amit kapila wrote:
>>
>> Patch implementing the design in below mail chain is attached with this
>> mail.
>
>
> This patch copies the ReadRecord() function and a bunch of related functions
> from xlog.c into pg_resetxlog.c. There's a separate patch in the current
> commitfest to make that code reusable, without having to copy-paste it to
> every tool that wants to parse the WAL. See
> https://commitfest.postgresql.org/action/patch_view?id=860. This patch
> should be refactored to make use of that framework, as soon as it's
> committed.

Agreed, moving to next commitfest.

Amit, suggest review of the patch that this now depends upon.

-- 
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services