Re: Should I implement DROP INDEX CONCURRENTLY?

Simon Riggs <simon@2ndquadrant.com>

View thread

From: Simon Riggs <simon@2ndQuadrant.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Peter Eisentraut <peter_e@gmx.net>, Daniel Farina <daniel@heroku.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2012-02-01T17:18:59Z

Lists: pgsql-hackers

Attachments

drop_index_concurrently.v5.patch (text/x-diff) patch v5

On Wed, Feb 1, 2012 at 2:56 AM, Robert Haas <robertmhaas@gmail.com> wrote:

> I improved the grammar issues in the attached version of the patch -
> the syntax is now simpler and more consistent, IF EXISTS now works,
> and RESTRICT is accepted (without changing the behavior) while CASCADE
> fails with a nicer error message.  I also fixed a bug in
> RangeVarCallbackForDropRelation.

Plus tests as well. Many thanks.

I fixed the main bug you observed and your test case now works
perfectly. I used pgbench to continuously drop/create an index, so a
little more than manual testing.

v5 Attached.

-- 
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services