Horton
Menu

Re: Review: Extra Daemons / bgworker

Simon Riggs <simon@2ndquadrant.com>

View thread
From: Simon Riggs <simon@2ndQuadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Markus Wanner <markus@bluegap.ch>, kaigai@kaigai.gr.jp, PostgreSQL-development Hackers <pgsql-hackers@postgresql.org>
Date: 2012-12-05T21:46:03Z
Lists: pgsql-hackers 
On 5 December 2012 15:09, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> Here's a first attempt at a new documentation chapter.  This goes in
> part "Server Programming", just after the SPI chapter.
>
> I just noticed that worker_spi could use some more sample code, for
> example auth_counter was getting its own LWLock and also its own shmem
> area, which would be helpful to demonstrate I think.

"to run once" -> "to run when"

Prefer
BgWorkerStart_ConsistentState to be renamed to BgWorkerRun_InHotStandby
BgWorkerStart_RecoveryFinished to be renamed to BgWorkerRun_InNormalMode

presumably a process will shutdown if (BgWorkerRun_InHotStandby &&
!BgWorkerRun_InNormalMode)


-- 
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services