Re: Poorly thought out code in vacuum

Simon Riggs <simon@2ndquadrant.com>

From: Simon Riggs <simon@2ndQuadrant.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org

Date: 2012-01-06T14:53:33Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Make VACUUM avoid waiting for a cleanup lock, where possible.
- bbb6e559c4ea 9.2.0 cited

On Fri, Jan 6, 2012 at 2:29 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Thu, Jan 5, 2012 at 7:37 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I suppose Robert had something more intelligent in mind than a tight
>> loop when the buffer can't be exclusively locked, so maybe there is
>> some other change that should be made here instead.
>
> My intention was to skip the tuple, but I failed to notice the unusual
> way in which this loop iterates.  How about something like the
> attached?

It solves the waiting issue, but leaves unused tuples in the heap that
previously would have been removed.

I don't think that is a solution.

-- 
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services