Horton

Re: Add pg_file_sync() to adminpack

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Atsushi Torikoshi <atorik@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Michael Paquier <michael@paquier.xyz>, Julien Rouhaud <rjuju123@gmail.com>, Arthur Zakirov <zaartur@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-01-16T14:51:24Z
Lists: pgsql-hackers 
On Tue, Jan 14, 2020 at 10:08 AM Atsushi Torikoshi <atorik@gmail.com> wrote:
> fails we can get error messages. So it seems straightforward for me to
>  'return true on success and emit an ERROR otherwise'.

I agree with reporting errors using ERROR, but it seems to me that we
ought to then make the function return 'void' rather than 'bool'.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Add pg_file_sync() to adminpack extension.