Re: postgres_fdw: using TABLESAMPLE to collect remote sample

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-02-11T18:13:46Z
Lists: pgsql-hackers
On Fri, Feb 11, 2022 at 1:06 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> While I'm not opposed to moving those goalposts at some point,
> I think pushing them all the way up to 9.5 for this one easily-fixed
> problem is not very reasonable.
>
> Given other recent discussion, an argument could be made for moving
> the cutoff to 9.2, on the grounds that it's too hard to test against
> anything older.  But that still leaves us needing a version check
> if we want to use TABLESAMPLE.

OK, thanks.

-- 
Robert Haas
EDB: http://www.enterprisedb.com



Commits

  1. Check relkind before using TABLESAMPLE in postgres_fdw

  2. Fix stale comment about sample_frac adjustment