Thread

1. Improvement of log messages in pg_basebackup

   Fujii Masao <masao.fujii@gmail.com> — 2012-03-27T09:25:27Z

   Hi,
   
   >	fprintf(stderr, _("%s: could not identify system: %s\n"),
   >			progname, PQerrorMessage(conn));
   
   Since PQerrorMessage() result includes a trailing newline, the above
   log message in pg_basebackup doesn't need to include a trailing \n.
   Attached patch gets rid of that \n.
   
   >	res = PQgetResult(conn);
   >	if (PQresultStatus(res) != PGRES_TUPLES_OK)
   >	{
   >		fprintf(stderr, _("%s: could not get WAL end position from server\n"),
   >				progname);
   
   ISTM it's worth including PQerrorMessage() result in the above log
   message, to diagnose the cause of error. Attached patch does that.
   
   Regards,
   
   -- 
   Fujii Masao
   NIPPON TELEGRAPH AND TELEPHONE CORPORATION
   NTT Open Source Software Center
   

2. Re: Improvement of log messages in pg_basebackup

   Robert Haas <robertmhaas@gmail.com> — 2012-03-28T12:44:17Z

   On Tue, Mar 27, 2012 at 5:25 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
   >>       fprintf(stderr, _("%s: could not identify system: %s\n"),
   >>                       progname, PQerrorMessage(conn));
   >
   > Since PQerrorMessage() result includes a trailing newline, the above
   > log message in pg_basebackup doesn't need to include a trailing \n.
   > Attached patch gets rid of that \n.
   >
   >>       res = PQgetResult(conn);
   >>       if (PQresultStatus(res) != PGRES_TUPLES_OK)
   >>       {
   >>               fprintf(stderr, _("%s: could not get WAL end position from server\n"),
   >>                               progname);
   >
   > ISTM it's worth including PQerrorMessage() result in the above log
   > message, to diagnose the cause of error. Attached patch does that.
   
   Committed.
   
   -- 
   Robert Haas
   EnterpriseDB: http://www.enterprisedb.com
   The Enterprise PostgreSQL Company