Horton

Re: making relfilenodes 56 bits

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Heikki Linnakangas <hlinnaka@iki.fi>, Thomas Munro <thomas.munro@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-06-30T17:27:13Z
Lists: pgsql-hackers 
On Wed, Jun 29, 2022 at 5:15 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> >- It looks to me like you need to give significantly more thought to
> > the proper way of adjusting the relfilenode-related test cases in
> > alter_table.out.
>
> It seems to me that this test case is just testing whether the
> table/child table are rewritten or not after the alter table.  And for
> that it is comparing the oid with the relfilenode, now that is not
> possible so I think it's quite reasonable to just compare the current
> relfilenode with the old relfilenode and if they are same the table is
> not rewritten.  So I am not sure why the original test case had two
> cases 'own' and 'orig'.  With respect to this test case they both have
> the same meaning, in fact comparing old relfilenode with current
> relfilenode is better way of testing than comparing the oid with
> relfilenode.

I think you're right. However, I don't really like OTHER showing up in
the output, because that looks like a string that was chosen to be
slightly alarming, especially given that it's in ALL CAPS. How about
if we change 'ORIG' to 'new'?

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Fix typos in comments, code and documentation

  2. Increase width of RelFileNumbers from 32 bits to 56 bits.

  3. Move RelFileNumber declarations to common/relpath.h.

  4. Include RelFileLocator fields individually in BufferTag.

  5. Convert macros to static inline functions (buf_internals.h)

  6. Remove the restriction that the relmap must be 512 bytes.

  7. Change internal RelFileNode references to RelFileNumber or RelFileLocator.

  8. Reorder subskiplsn in pg_subscription to avoid alignment issues.

  9. Fix DROP {DATABASE,TABLESPACE} on Windows.

  10. Restructure smgr API as per recent proposal. smgr no longer depends on