Horton

Re: new heapcheck contrib module

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>, Dilip Kumar <dilipbalaut@gmail.com>, Peter Geoghegan <pg@bowt.ie>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-07-31T19:16:39Z
Lists: pgsql-hackers 
On Fri, Jul 31, 2020 at 3:05 PM Andres Freund <andres@anarazel.de> wrote:
> The page could have been wrongly marked all-frozen. There could be
> interactions between heap and toast table that are checked. Other bugs
> could apply, like a broken hot chain or such.

OK, at least the first two of these do sound like problems. Not sure
about the third one.

> > If we do need to do something special in terms of advertising xmin,
> > how would you do it? Normally it happens by registering a snapshot,
> > but here all we would have is an XID; specifically, the value of
> > relfrozenxid that we observed.
>
> An appropriate procarray or snapmgr function would probably suffice?

Not sure; I guess that'll need some investigation.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Add pg_amcheck, a CLI for contrib/amcheck.

  2. Refactor and generalize the ParallelSlot machinery.

  3. Generalize parallel slot result handling.

  4. Move some code from src/bin/scripts to src/fe_utils to permit reuse.

  5. Factor pattern-construction logic out of processSQLNamePattern.

  6. Doc: clean up verify_heapam() documentation.

  7. Fix more portability issues in new amcheck code.

  8. Fix portability issues in new amcheck test.

  9. Try to avoid a compiler warning about using fxid uninitialized.

  10. Extend amcheck to check heap pages.

  11. Adjust walsender usage of xlogreader, simplify APIs

  12. Improve checking of child pages in contrib/amcheck.

  13. Sanitize line pointers within contrib/amcheck.

  14. Fix possible sorting error when aborting use of abbreviated keys.