Horton

Thread

  1. patch for implementing SPI_gettypemod()

    Chetan Suttraway <chetan.suttraway@enterprisedb.com> — 2012-02-01T10:23:53Z

    Hi All,

This is regarding the TODO item :
"Add SPI_gettypmod() to return a field's typemod from a TupleDesc"

The related message is:
http://archives.postgresql.org/pgsql-hackers/2005-11/msg00250.php

This basically talks about having an SPI_gettypemod() which returns the
typmod of a field of tupdesc

Please refer the attached patch based on the suggested implementation.


Regards,
Chetan

-- 
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

 Website: www.enterprisedb.com
EnterpriseDB Blog : http://blogs.enterprisedb.com
Follow us on Twitter : http://www.twitter.com/enterprisedb

  2. Re: patch for implementing SPI_gettypemod()

    Robert Haas <robertmhaas@gmail.com> — 2012-02-02T14:41:46Z

    On Wed, Feb 1, 2012 at 5:23 AM, Chetan Suttraway
<chetan.suttraway@enterprisedb.com> wrote:
> Hi All,
>
> This is regarding the TODO item :
> "Add SPI_gettypmod() to return a field's typemod from a TupleDesc"
>
> The related message is:
> http://archives.postgresql.org/pgsql-hackers/2005-11/msg00250.php
>
> This basically talks about having an SPI_gettypemod() which returns the
> typmod of a field of tupdesc
>
> Please refer the attached patch based on the suggested implementation.

Please add this to the next CommitFest:

https://commitfest.postgresql.org/action/commitfest_view/open

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

  3. Re: patch for implementing SPI_gettypemod()

    Chetan Suttraway <chetan.suttraway@enterprisedb.com> — 2012-02-07T07:02:29Z

    On Thu, Feb 2, 2012 at 8:11 PM, Robert Haas <robertmhaas@gmail.com> wrote:

> On Wed, Feb 1, 2012 at 5:23 AM, Chetan Suttraway
> <chetan.suttraway@enterprisedb.com> wrote:
> > Hi All,
> >
> > This is regarding the TODO item :
> > "Add SPI_gettypmod() to return a field's typemod from a TupleDesc"
> >
> > The related message is:
> > http://archives.postgresql.org/pgsql-hackers/2005-11/msg00250.php
> >
> > This basically talks about having an SPI_gettypemod() which returns the
> > typmod of a field of tupdesc
> >
> > Please refer the attached patch based on the suggested implementation.
>
> Please add this to the next CommitFest:
>
> https://commitfest.postgresql.org/action/commitfest_view/open
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

At the given link, I am able to choose only "System administration" under
commitfest topic.
I think there has to be "server features" or "Miscellaneous".


Regards,
Chetan

-- 
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

 Website: www.enterprisedb.com
EnterpriseDB Blog : http://blogs.enterprisedb.com
Follow us on Twitter : http://www.twitter.com/enterprisedb

  4. Re: patch for implementing SPI_gettypemod()

    Peter Eisentraut <peter_e@gmx.net> — 2012-02-07T21:25:22Z

    On ons, 2012-02-01 at 15:53 +0530, Chetan Suttraway wrote:
> This is regarding the TODO item :
> "Add SPI_gettypmod() to return a field's typemod from a TupleDesc"

My first thought was, this should be spelled SPI_gettypmod().  Not sure
what others think.

  5. Re: patch for implementing SPI_gettypemod()

    Robert Haas <robertmhaas@gmail.com> — 2012-02-08T02:45:26Z

    On Tue, Feb 7, 2012 at 4:25 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On ons, 2012-02-01 at 15:53 +0530, Chetan Suttraway wrote:
>> This is regarding the TODO item :
>> "Add SPI_gettypmod() to return a field's typemod from a TupleDesc"
>
> My first thought was, this should be spelled SPI_gettypmod().  Not sure
> what others think.

+1.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

  6. Re: patch for implementing SPI_gettypemod()

    Chetan Suttraway <chetan.suttraway@enterprisedb.com> — 2012-02-08T06:49:56Z

    On Wed, Feb 8, 2012 at 8:15 AM, Robert Haas <robertmhaas@gmail.com> wrote:

> On Tue, Feb 7, 2012 at 4:25 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> > On ons, 2012-02-01 at 15:53 +0530, Chetan Suttraway wrote:
> >> This is regarding the TODO item :
> >> "Add SPI_gettypmod() to return a field's typemod from a TupleDesc"
> >
> > My first thought was, this should be spelled SPI_gettypmod().  Not sure
> > what others think.
>
> +1.
>
>
The reason for using SPI_gettypemod() name was that I did see
SPI_gettypeid().

Anyways, will update patch with recommended name.

Regards,
Chetan

-- 
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

 Website: www.enterprisedb.com
EnterpriseDB Blog : http://blogs.enterprisedb.com
Follow us on Twitter : http://www.twitter.com/enterprisedb

  7. Re: patch for implementing SPI_gettypemod()

    Chetan Suttraway <chetan.suttraway@enterprisedb.com> — 2012-02-08T06:58:48Z

    On Wed, Feb 8, 2012 at 12:19 PM, Chetan Suttraway <
chetan.suttraway@enterprisedb.com> wrote:

>
>
> On Wed, Feb 8, 2012 at 8:15 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>
>> On Tue, Feb 7, 2012 at 4:25 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
>> > On ons, 2012-02-01 at 15:53 +0530, Chetan Suttraway wrote:
>> >> This is regarding the TODO item :
>> >> "Add SPI_gettypmod() to return a field's typemod from a TupleDesc"
>> >
>> > My first thought was, this should be spelled SPI_gettypmod().  Not sure
>> > what others think.
>>
>> +1.
>>
>>
> The reason for using SPI_gettypemod() name was that I did see
> SPI_gettypeid().
>
> Anyways, will update patch with recommended name.
>
>
> Regards,
> Chetan
>
>
>
Please refer the attached patch  which now uses SPI_gettypmod() name.

Regards,
Chetan

-- 
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

 Website: www.enterprisedb.com
EnterpriseDB Blog : http://blogs.enterprisedb.com
Follow us on Twitter : http://www.twitter.com/enterprisedb