Horton

Re: Removing WITH clause support in CREATE FUNCTION, for isCachable and isStrict

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael.paquier@gmail.com>, Daniel Gustafsson <daniel@yesql.se>, Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2018-01-26T17:39:35Z
Lists: pgsql-hackers 
On Fri, Jan 26, 2018 at 12:30 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Michael Paquier <michael.paquier@gmail.com> writes:
>> On Thu, Jan 25, 2018 at 06:30:04PM -0500, Tom Lane wrote:
>>> In short, I'm on board with removing the WITH clause.  I've not
>>> reviewed the patch in detail, but will do so and push it if there's
>>> not objections pretty soon.
>
>> Glad to hear that, thanks!
>
> And done.  I failed to resist the temptation to rename
> compute_attributes_sql_style, since the "sql_style" bit no longer
> conveys anything.  I'd always found compute_attributes_with_style
> to be confusingly named --- seemed like it should have a sibling
> compute_attributes_gracelessly, or something like that.

+1 for compute_attributes_gracelessly!  :-)

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Remove the obsolete WITH clause of CREATE FUNCTION.

  2. Extend syntax of CREATE FUNCTION to resemble SQL99.