Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>,
Pg Hackers <pgsql-hackers@postgresql.org>, Rushabh Lathia <rushabh.lathia@gmail.com>,
Michael Paquier <michael.paquier@gmail.com>, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Date: 2018-02-28T15:20:44Z
Lists: pgsql-hackers
On Tue, Feb 27, 2018 at 5:14 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> I ran the postgres_fdw regression test with no sleep two times in a >> CLOBBER_CACHE_ALWAYS-enabled build, and then the regression test with >> the sleep (60 seconds) two times, but I couldn't reproduce that in both >> cases. I suspect the changes in the order of the RETURNING output there >> was still caused by autovacuum kicking in partway through the run. So >> to make the regression test more stable against autovacuum, I'd propose >> to modify the regression test to disable autovacuum for the remote table >> (ie "S 1"."T 1") (and perform VACUUM ANALYZE to that table manually >> instead) in hopes of getting that fixed. Attached is a patch for that. >> I think changes added by the previous patch wouldn't make sense >> anymore, so I removed those changes. > > Ping? We're still seeing those failures on jaguarundi. This is another patch that got past me. Committed now. I'd be lying if I said I was filled with confidence that this was going to fix it, but I don't know what to do other than keep tinkering with it until we find something that works. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
Temporarily instrument postgres_fdw test to look for statistics changes.
- c2c537c56dc3 11.0 landed
-
postgres_fdw: Fourth attempt to stabilize regression tests.
- 1733460f0205 11.0 landed
-
postgres_fdw: Third attempt to stabilize regression tests.
- 4fa396464e5f 11.0 landed
-
postgres_fdw: Attmempt to stabilize regression tests.
- 958e20e42d6c 11.0 landed
-
postgres_fdw: Push down UPDATE/DELETE joins to remote servers.
- 1bc0100d270e 11.0 landed