Re: REINDEX CONCURRENTLY 2.0
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Andres Freund <andres@2ndquadrant.com>
Cc: Peter Eisentraut <peter_e@gmx.net>,
Michael Paquier <michael.paquier@gmail.com>, Jim Nasby <jim@nasby.net>,
PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2014-11-17T16:06:05Z
Lists: pgsql-hackers
On Fri, Nov 14, 2014 at 11:47 AM, Andres Freund <andres@2ndquadrant.com> wrote: > On 2014-11-13 11:41:18 -0500, Robert Haas wrote: >> On Wed, Nov 12, 2014 at 7:31 PM, Andres Freund <andres@2ndquadrant.com> wrote: >> > But I think it won't work realistically. We have a *lot* of >> > infrastructure that refers to indexes using it's primary key. I don't >> > think we want to touch all those places to also disambiguate on some >> > other factor. All the relevant APIs are either just passing around oids >> > or relcache entries. >> >> I'm not quite following this. The whole point is to AVOID having two >> indexes. You have one index which may at times have two sets of >> physical storage. > > Right. But how are we going to refer to these different relfilenodes? > All the indexing infrastructure just uses oids and/or Relation pointers > to refer to the index. How would you hand down the knowledge which of > the relfilenodes is supposed to be used in some callchain? If you've got a Relation, you don't need someone to tell you which physical storage to use; you can figure that out for yourself by looking at the Relation. If you've got an OID, you're probably going to go conjure up a Relation, and then you can do the same thing. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
Prevent reindex of invalid indexes on TOAST tables
- 8bca5f93547c 12.3 landed
- 61d7c7bce368 13.0 landed
-
Rework handling of invalid indexes with REINDEX CONCURRENTLY
- a6dcf9df4d91 12.0 landed
-
Split builtins.h to a new header ruleutils.h
- 7b1c2a0f2066 9.5.0 cited