Re: factorial function/phase out postfix operators?
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>,
John Naylor <john.naylor@2ndquadrant.com>, Vik Fearing <vik@postgresfriends.org>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-09-18T17:42:53Z
Lists: pgsql-hackers
On Fri, Sep 18, 2020 at 11:29 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: > I confess to not having paid very close attention to this thread > lately, but the last I'd noticed the terminology proposed for > internal use was "bare column label", which I think is much better. I agree. > As for what to expose in pg_get_keywords, I think something like > "label_requires_as bool" would be immediately understandable. > If you really want it to be an enum sort of thing, maybe the output > column title could be "collabel" with values "bare" or "requires_AS". It's sort of possible to be confused by "label requires as" since "as" is being used as a known but isn't really one generally speaking, but we can't very well quote it so I don't know how to make it more clear. > So I'm thinking about making these changes in gram.y: > > ImplicitAlias -> BareColLabel > implicit_alias_keyword -> bare_label_keyword > > and corresponding terminology changes elsewhere. +1. Thanks for picking this up; I am pretty excited about this. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
Remove precedence hacks no longer needed without postfix operators.
- 28a61fc6c58f 14.0 landed
-
Allow most keywords to be used as column labels without requiring AS.
- 06a7c3154f5b 14.0 landed
-
Remove support for postfix (right-unary) operators.
- 1ed6b895634c 14.0 landed
-
Remove factorial operators, leaving only the factorial() function.
- 76f412ab3105 14.0 landed
-
Further refine patch for commenting operator implementation functions.
- 908ab8028640 9.1.0 cited