Re: increasing the default WAL segment size

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Michael Paquier <michael.paquier@gmail.com>

Cc: Andres Freund <andres@anarazel.de>, Beena Emerson <memissemerson@gmail.com>, Jim Nasby <Jim.Nasby@bluetreble.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2017-01-27T22:29:44Z

Lists: pgsql-hackers

On Thu, Jan 26, 2017 at 8:53 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
>> I've not done like the most careful review ever, but I'm in favor of the
>> general change (provided the byval thing is fixed obviously).
>
> Thanks for the review.

Why not use pg_ltoa and pg_lltoa like the output functions for the datatype do?

Might use CStringGetTextDatum(blah) instead of
PointerGetDatum(cstring_to_text(blah)).

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Make WAL segment size configurable at initdb time.
- fc49e24fa69a 11.0 landed
Perform only one ReadControlFile() during startup.
- 8356753c212a 11.0 landed
Introduce BYTES unit for GUCs.
- 6e7baa322773 11.0 landed
Remove useless duplicate inclusions of system header files.
- 9e3755ecb2d0 10.0 cited
Refactor other replication commands to use DestRemoteSimple.
- bbd8550bce14 10.0 landed
Add a SHOW command to the replication command language.
- d1ecd539477f 10.0 landed
Add a new DestReceiver for printing tuples without catalog access.
- a84069d93504 10.0 landed
Support fls().
- 4f658dc851a7 9.2.0 cited
Extend yesterday's patch making BLCKSZ and RELSEG_SIZE configurable to also
- cf9f6c8d8e9d 8.4.0 cited
Commit the reasonably uncontroversial parts of J.R. Nield's PITR patch, to
- c3c09be34b6b 8.0.0 cited
XLOG (also known as WAL -:)) Bootstrap/Startup/Shutdown.
- 47937403676d 7.1.1 cited
Transaction log manager core code.
- 30659d43eb73 7.1.1 cited