Horton

Re: pgsql: Server-side gzip compression.

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-01-25T18:12:30Z
Lists: pgsql-hackers 
On Tue, Jan 25, 2022 at 4:20 AM David Rowley <dgrowleyml@gmail.com> wrote:
> On Tue, 25 Jan 2022 at 09:14, Robert Haas <rhaas@postgresql.org> wrote:
> > src/backend/replication/basebackup_gzip.c | 309 ++++++++++++++++++++++++++++++
>
> This could do with the attached.  MSVC compilers need a bit more
> reassurance that ereport/elog ERRORs don't return.

Err, well, if we need it, we need it. It surprises me, though:
wouldn't this same consideration apply to a very large number of other
places in the code base?

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. pg_basebackup: Add a dummy return to bbsink_gzip_new().

  2. Server-side gzip compression.

  3. Extend the options of pg_basebackup to control compression

  4. Support base backup targets.

  5. Flexible options for BASE_BACKUP.