Re: [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Jeff Janes <jeff.janes@gmail.com>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, David Christensen <david@endpoint.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-03-10T01:57:05Z
Lists: pgsql-hackers
On Thu, Mar 9, 2017 at 8:47 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> writes: >> On 2017/03/10 9:14, Jeff Janes wrote: >>> I think we can just save $. and use that, as in the attached. > >> The patch works for me. > > Me too. Pushed; we'll soon see if that makes the oldest buildfarm > critters happy. $. has been around since the stone age (a.k.a. when I was a teenager) so we should be fine there. I hope. That whole input_line_number thing was making me a bit nervous, but I couldn't find any reference to when that had been added in a quick Google search, which gave me hope that it was old enough that we'd be OK. Sorry for the hassle. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
Fix portability problem in Catalog.pm.
- 15bb93e28e49 10.0 landed
-
Throw an error if a DATA() line contains wrong # of attributes.
- 7666e73a2e9e 10.0 landed