Re: [PATCH] Add tests for Bitmapset

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Greg Burd <greg@burd.me>

Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Nathan Bossart <nathandbossart@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>

Date: 2025-09-17T13:55:12Z

Lists: pgsql-hackers

On Wed, Sep 17, 2025 at 9:18 AM Greg Burd <greg@burd.me> wrote:
> > +static void
> > +elog_bitmapset(int elevel, const char *label, const Bitmapset *bms)
> >
>
> I added a function bms_values() that prints out the values contained in
> a bitmapset and changed a few tests to use it.  I removed the
> elog_bitmapset() as it isn't being used and now that it's easy to output
> the set in SQL why keep it for debugging?

How about using outBitmapset() which already exists?

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Minor fixes for test_bitmapset.c
- 5142f0093e64 19 (unreleased) landed
test_bitmapset: Improve random function
- 9d46b86529e8 19 (unreleased) landed
Add mem_exceeded_count column to pg_stat_replication_slots.
- d3b6183dd988 19 (unreleased) landed
Tidy-up unneeded NULL parameter checks from SQL function
- a69b55cd4727 19 (unreleased) landed
Remove check for NULL in STRICT function
- 381f5cffae00 19 (unreleased) landed
Fixes for comments in test_bitmapset
- a1b064e4b226 19 (unreleased) landed
Minor fixups of test_bitmapset.c
- 3a6615806859 19 (unreleased) landed
test_bitmapset: Simplify code of the module
- 9952f6c05a40 19 (unreleased) landed
test_bitmapset: Expand more the test coverage
- 5668fff3c512 19 (unreleased) landed
Fix compiler warnings in test_bitmapset
- f83fe65f3fc1 19 (unreleased) landed
Add a test module for Bitmapset
- 00c3d87a5cab 19 (unreleased) landed