Horton
Menu

Re: 'converts internal representation to "..."' comment is confusing

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Steve Chavez <steve@supabase.io>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2023-05-16T12:49:36Z
Lists: pgsql-hackers 
On Sun, May 14, 2023 at 9:37 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Steve Chavez <steve@supabase.io> writes:
> > I found "..." confusing in some comments, so this patch changes it to
> > "cstring". Which seems to be the intention after all.
>
> Those comments are Berkeley-era, making them probably a decade older
> than the "cstring" pseudotype (invented in b663f3443).  Perhaps what
> you suggest is an improvement, but I'm not sure that appealing to
> original intent can make the case.

FWIW, it does seem like an improvement to me.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Change "..." to cstring in old input/output function comments.