Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix pg_get_functiondef to dump parallel-safety markings.

  2. Determine whether it's safe to attempt a parallel plan for a query.

  1. Parallel indicators not written by pg_get_functiondef

    Feike Steenbergen <feikesteenbergen@gmail.com> — 2016-04-15T11:48:24Z

    pg_get_functiondef(oid) does not return the PARALLEL indicators.

Attached a small patch to have pg_get_functiondef actually add these
indicators, using commit 7aea8e4f2 (pg_dump.c) as a guide.

The logic is the same as with the volatility: we only append non-default
indicators.

Feike Steenbergen

  2. Re: Parallel indicators not written by pg_get_functiondef

    Michael Paquier <michael.paquier@gmail.com> — 2016-04-15T12:13:47Z

    On Fri, Apr 15, 2016 at 8:48 PM, Feike Steenbergen
<feikesteenbergen@gmail.com> wrote:
> pg_get_functiondef(oid) does not return the PARALLEL indicators.
>
> Attached a small patch to have pg_get_functiondef actually add these
> indicators, using commit 7aea8e4f2 (pg_dump.c) as a guide.
>
> The logic is the same as with the volatility: we only append non-default
> indicators.

+1 for a good catch. Your patch is correct.
-- 
Michael

  3. Re: Parallel indicators not written by pg_get_functiondef

    Feike Steenbergen <feikesteenbergen@gmail.com> — 2016-04-27T07:02:05Z

    This patch is redundant as of
commit 2ac3be2e763d9b971352819f285dd51519e0aeb9

(Ashutosh Sharma diagnosed and patched the same problem)

On 15 April 2016 at 14:13, Michael Paquier <michael.paquier@gmail.com>
wrote:

> On Fri, Apr 15, 2016 at 8:48 PM, Feike Steenbergen
> <feikesteenbergen@gmail.com> wrote:
> > pg_get_functiondef(oid) does not return the PARALLEL indicators.
> >
> > Attached a small patch to have pg_get_functiondef actually add these
> > indicators, using commit 7aea8e4f2 (pg_dump.c) as a guide.
> >
> > The logic is the same as with the volatility: we only append non-default
> > indicators.
>
> +1 for a good catch. Your patch is correct.
> --
> Michael
>

  4. Re: Parallel indicators not written by pg_get_functiondef

    Robert Haas <robertmhaas@gmail.com> — 2016-04-27T21:06:00Z

    On Wed, Apr 27, 2016 at 3:02 AM, Feike Steenbergen
<feikesteenbergen@gmail.com> wrote:
> This patch is redundant as of commit
> 2ac3be2e763d9b971352819f285dd51519e0aeb9
>
> (Ashutosh Sharma diagnosed and patched the same problem)

Oops.  I completely failed to notice this prior report.

Sorry about that.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company