Horton

Re: logical replication launcher crash on buildfarm

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Petr Jelinek <petr@2ndquadrant.com>, Peter Eisentraut <peter_e@gmx.net>
Date: 2017-03-31T13:42:31Z
Lists: pgsql-hackers 
On Tue, Mar 28, 2017 at 7:39 PM, Petr Jelinek
<petr.jelinek@2ndquadrant.com> wrote:
> Sigh, forgot git add for the docs, so one more try...

+    if (strncmp(worker->bgw_library_name, "postgres", 8) != 0)
+        return NULL;

I think that's not right.  You don't want to match postgresshdkgjsdglkjs.

Aside from that, these look good to me.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Avoid passing function pointers across process boundaries.

  2. Don't use bgw_main even to specify in-core bgworker entrypoints.