Re: performance issue in remove_from_unowned_list()
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-03-13T12:12:01Z
Lists: pgsql-hackers
On Tue, Mar 12, 2019 at 6:54 PM Tomas Vondra <tomas.vondra@2ndquadrant.com> wrote: > Attached is a patch adopting the dlist approach - it seems to be working > quite fine, and is a bit cleaner than just slapping another pointer into > the SMgrRelationData struct. So I'd say this is the way to go. What about using a data structure that supports O(1) lookups for any element? The current efforts all seem to revolve around correctly guessing from which end of the list we are likely to delete stuff, but your research suggests that we don't always make such guesses particularly well. And it seems unnecessary. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
Track unowned relations in doubly-linked list
- 31737eb43ffd 9.4.22 landed
- 261aa218c9a0 9.5.17 landed
- 0a5dcb87aec7 9.6.13 landed
- 5601f9fb97d1 10.8 landed
- fb0b5b0b84a0 11.3 landed
- 6ca015f9f073 12.0 landed