Horton

Re: factorial function/phase out postfix operators?

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, John Naylor <john.naylor@2ndquadrant.com>, Vik Fearing <vik@postgresfriends.org>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-09-11T19:54:28Z
Lists: pgsql-hackers 
On Fri, Sep 11, 2020 at 3:23 PM Mark Dilger
<mark.dilger@enterprisedb.com> wrote:
> Another option would be to have pg_dump take a strictness mode option.  I don't think the option should have anything to do with postfix operators specifically, but be more general like --dump-incompatible-objects vs. --omit-incompatible-objects vs. --error-on-incompatible-objects vs. --do-your-best-to-fixup-incompatible-objects, with one of those being the default (and with all of them having better names).  If --error-on-incompatible-objects were the default, that would behave as Robert recommended upthread.
>
> I can totally see an objection to the added complexity of such options, so I'm really just putting this out on the list for comment.

I'm not opposed to Tom's proposal. I just wanted to raise the issue
for discussion.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Remove precedence hacks no longer needed without postfix operators.

  2. Allow most keywords to be used as column labels without requiring AS.

  3. Remove support for postfix (right-unary) operators.

  4. Remove factorial operators, leaving only the factorial() function.

  5. Further refine patch for commenting operator implementation functions.