Re: Major Version Upgrade failure due to orphan roles entries in catalog

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Laurenz Albe <laurenz.albe@cybertec.at>, Virender Singla <virender.cse@gmail.com>, pgsql-bugs@lists.postgresql.org, Aniket Jha <aniketkumarj@gmail.com>

Date: 2025-03-04T15:17:07Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Avoid race condition between "GRANT role" and "DROP ROLE".
- 98fc31d64991 18.0 landed
Fix pg_dumpall to cope with dangling OIDs in pg_auth_members.
- d850a6600cec 16.9 landed
- ce1475acd5e2 14.18 landed
- 6df3be415cdb 15.13 landed
- 29d75b25b567 18.0 landed
- 16eff4261f46 17.5 landed
- 5302ff95cadd 13.21 landed
Ensure that pg_auth_members.grantor is always valid.
- 6566133c5f52 16.0 cited

On Thu, Feb 13, 2025 at 12:07 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> The code the attached patch is touching is from commit 6566133c5.
> I'm not going to blame the bug on that commit, because before that
> we had dependencies on *zero* of the three roles; at least it added
> one on the grantor.  But I'm wondering whether Robert thought about
> the other two roles and explicitly rejected making dependencies
> for them, and if so why.

For some reason, I came to the conclusion that it wasn't needed.
Apparently, that was incorrect.

-- 
Robert Haas
EDB: http://www.enterprisedb.com