Re: PartitionDispatch's partdesc field

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2018-07-27T13:44:54Z
Lists: pgsql-hackers
On Wed, Jul 25, 2018 at 10:42 PM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> Another alternative, which I think might make more sense, is to make
>> use pd->key and pd->partdesc in preference to pd->reldesc->rd_partkey
>> and pd->reldesc->rd_partdesc.  It seems to me that the idea of the
>> PartitionDispatch structure is that it gathers together all of the
>> information that we need for tuple routing, so it might make sense for
>> the tuple routing code ought to get the information from there rather
>> than referring back to the RelationDesc.  See attached
>> pd-partdesc-use.patch.
>
> +1 to pd-partdesc-use.patch.

OK, that makes 2 votes for that alternative and 0 for everything else
combined, so I've committed that version.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Commits

  1. Use key and partdesc from PartitionDispatch where possible.