Re: Incorrect comment in be-secure-openssl.c

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-05-31T21:47:01Z
Lists: pgsql-hackers
On Sun, May 31, 2020 at 2:54 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Fri, May 29, 2020 at 02:38:53PM +0900, Michael Paquier wrote:
> > Indeed, looks good to me.  I'll go fix, ust let's wait and see first
> > if others have any comments.
>
> Actually, I was reading again the new sentence, and did not like its
> first part.  Here is a rework that looks much better to me:
>   * Load hardcoded DH parameters.
>   *
> - * To prevent problems if the DH parameter files don't even exist, we
> - * can load hardcoded DH parameters supplied with the backend.
> + * If DH parameters cannot be loaded from a specified file, we can load
> + * the hardcoded DH parameters supplied with the backend to prevent
> + * problems.
>
> Daniel, is that fine for you?

I don't understand why that change is an improvement.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



Commits

  1. Fix comment in be-secure-openssl.c

  2. Move EDH support to common files