Horton

Re: auxiliary processes in pg_stat_ssl

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Kuntal Ghosh <kuntalghosh.2007@gmail.com>
Date: 2019-11-04T14:28:30Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_stat_activity: document client_port being null

  2. pg_stat_{ssl,gssapi}: Show only processes with connections

On Mon, Nov 4, 2019 at 8:26 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> On 2019-Sep-04, Alvaro Herrera wrote:
> > I just noticed that we list auxiliary processes in pg_stat_ssl:
> [...]
> > But this seems pointless.  Should we not hide those?  Seems this only
> > happened as an unintended side-effect of fc70a4b0df38.  It appears to me
> > that we should redefine that view to restrict backend_type that's
> > 'client backend' (maybe include 'wal receiver'/'wal sender' also, not
> > sure.)
>
> [crickets]
>
> Robert, Kuntal, any opinion on this?

I think if I were doing something about it, I'd probably try to filter
on a field that directly represents whether there is a connection,
rather than checking the backend type. That way, if the list of
backend types that have client connections changes later, there's
nothing to update. Like "WHERE client_port IS NOT NULL," or something
of that sort.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company