Re: [sqlsmith] Unpinning error in parallel worker
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Andreas Seltenreich <seltenreich@gmx.de>,
Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-04-05T14:18:11Z
Lists: pgsql-hackers
On Wed, Apr 5, 2017 at 3:59 AM, Thomas Munro <thomas.munro@enterprisedb.com> wrote: > On Thu, Mar 30, 2017 at 3:50 AM, Robert Haas <robertmhaas@gmail.com> wrote: >> On Wed, Mar 29, 2017 at 1:31 AM, Thomas Munro >> <thomas.munro@enterprisedb.com> wrote: >>> I considered whether the error message could be improved but it >>> matches the message for an existing similar case (where you try to >>> attach to an unknown handle). >> >> Ugh, OK. I committed this, but I think this whole file needs a visit >> from the message style police. > > Like this? I was thinking of maybe not creating two separate (translatable) messages, and just using "could not attach to dynamic shared area" for both. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
Use English, instead of internal names, for translatable messages.
- 5c4488478b18 10.0 landed
-
Plug race in dsa_attach.
- fddf45b38097 10.0 landed