Horton

Re: Invalidate the subscription worker in cases where a user loses their superuser status

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Jeff Davis <pgsql@j-davis.com>, vignesh C <vignesh21@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-09-28T15:34:14Z
Lists: pgsql-hackers 
On Wed, Sep 27, 2023 at 2:58 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> But OTOH, the owner of the subscription can be changed by the Alter
> Subscription command whereas superuser status can't be changed. I
> think we should consider changing the message for this case.

The superuser status of the subscription owner is definitely *not* a
parameter of the subscription, so it doesn't seem like the same
message is appropriate.

> Adding Jeff and Robert to see what is their opinion on whether we
> should backpatch this or not.

I guess it depends on whether we think this is a bug. I think you
could argue it either way.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Restart the apply worker if the privileges have been revoked.