Horton

Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: "David E. Wheeler" <david@justatheory.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>, Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>, Mankirat Singh <mankiratsingh1315@gmail.com>
Date: 2025-10-30T20:10:03Z
Lists: pgsql-hackers 
On Thu, Oct 30, 2025 at 8:42 AM David E. Wheeler <david@justatheory.com> wrote:
> Might I suggest, however, that it also run for branches matching /_STABLE$/ even if there is no .abi-hstory-file? The whole point of this exercise was to increase the confidence in ABI stability in stable branches. Running it in such branches would help remind maintainers to add the file.

I think it is better to do as Tom suggests -- i.e. have a buildfarm
client that only cares about the presence of the file, and not at all
about the name of the branch. That gives us the maximum amount of
future flexibility for no real cost. Said differently, if somebody
nukes the ABI history file from a back-branch, I think we should
assume that represents a deliberate decision on the part of the
project to stop caring about ABI compatibility in that particular
back-branch, not an error that the build-farm needs to flag. Of
course, if somebody wants to argue that such a decision was wrongly
made, they're free to do so on pgsql-hackers, but we'd like the
buildfarm to be green rather than red while that's being litigated.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Add commit 24f6c1bd4 to v17 .abi-compliance-history.

  2. Add .abi-compliance-history to back-branches.

  3. Add reminder to create .abi-compliance-history.

  4. Update .abi-compliance-history file.

  5. Add .abi-compliance-history to v18 branch.

  6. Fix thinko in commit 7d129ba54.

  7. Fix lookups in pg_{clear,restore}_{attribute,relation}_stats().

  8. Add defenses against unexpected changes in the NodeTag enum list.